fix(linter)!: remove react from default plugin set #11382

camc314 · 2025-05-29T22:33:22Z

This is a breaking change, but currently, how we check whether a react rule should run is opaque and unclear.

For example, the react/forward-ref-uses-ref rule checks whether the framework flags FrameworkFlags::React is enabled, however this is never set to true meaning that this rule can never run.

oxc/crates/oxc_linter/src/rules/react/forward_ref_uses_ref.rs

Lines 99 to 101 in bbb7eb1

    
           fn should_run(&self, ctx: &ContextHost) -> bool { 
        
               ctx.frameworks().contains(FrameworkFlags::React) 
        
           }

This PR removes the react rule group from the default plugins, if users which to use the react plugin, they just have to add it to the plugins array.

I have made thie change before 1.0, so hopefully the fact that it's breaking is ok.

camc314 · 2025-05-29T22:33:37Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-05-29T22:38:18Z

CodSpeed Instrumentation Performance Report

Merging #11382 will not alter performance

_{Comparing c/05-29-fix_linter_remove_react_from_default_plugin_set (ead5309) with main (8a34447)}

Summary

✅ 38 untouched benchmarks

camc314 · 2025-05-30T07:42:40Z

Merge activity

May 30, 7:42 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
May 30, 7:42 AM UTC: camc314 added this pull request to the Graphite merge queue.
May 30, 7:52 AM UTC: Merged by the Graphite merge queue.

This is a breaking change, but currently, how we check whether a react rule should run is opaque and unclear. For example, the `react/forward-ref-uses-ref` rule checks whether the framework flags `FrameworkFlags::React` is enabled, however this is never set to true meaning that this rule can never run. https://github.com/oxc-project/oxc/blob/bbb7eb1a27ac280febc3702bc5e7eb131dcc005a/crates/oxc_linter/src/rules/react/forward_ref_uses_ref.rs#L99-L101 This PR removes the react rule group from the default plugins, if users which to use the react plugin, they just have to add it to the plugins array. I have made thie change before 1.0, so hopefully the fact that it's breaking is ok.

## [0.17.0] - 2025-05-30 - ead5309 linter: [**BREAKING**] Remove react from default plugin set (#11382) (camc314) ### Features - 2d25bd8 linter: Remove `unicorn/no-for-loop` over `typescript/prefer-for-of` (#11354) (camc314) - bbb7eb1 linter: Add auto-fix to react/forward-ref-uses-ref (#11342) (yefan) - 590c27b linter: Add auto-fix to unicorn/no-await-expression-member (#11306) (yefan) - 7824f01 linter: Implement suggestion for `jsx/no-useless-fragment` (#10800) (Cam McHenry) - 2083d33 linter/language_server: Add second editor suggestion for `react/forward-ref-uses-ref` (#11375) (Sysix) ### Bug Fixes - f6424dd linter: Reflect react plugin is disabled by default in cli (#11397) (camc314) - 25ecbfe linter: Remove use of `FrameworkFlags::React` to decide whether rules should run (#11383) (camc314) - 0d240e4 linter: False positive in react/exhaustive-deps with default formal parameter (#11395) (camc314) - c91697e linter: Fix panic in multi byte char in `TryFrom` aria (#11350) (camc314) - 9798ef1 linter: Stack overflow in no-async-endpoint-handlers (#11317) (camc314) - 348ad97 linter: Skip no-unused-vars on astro files (#11303) (camc314) - 183d7f0 linter: Make `jest/no-large-snapshots` error easier to comprehend (#11294) (Ulrich Stark) - 4e606a5 linter: Improve `jest/no-large-snapshots` (#11291) (Ulrich Stark) - 14f790f linter: Improve `jest/no-restricted-matchers` (#11292) (Ulrich Stark) - a2c82be linter/block-scoped-var: Better diagnostic messages (#11290) (DonIsaac) - 19772e5 linter/no-unused-vars: Panic when variable is redeclared as function in same scope (#11280) (Dunqing) - 7af5bb1 oxc_language_server: Include save option for text document sync capability (#11297) (Nicholas Rayburn) ### Performance - 0ed6c1a language_server: Use `Arc<RwLock>` instead of `Mutex` for workspace workers (#11328) (Sysix) - a0ee946 linter: Reduce code size in `globals` (#11333) (shulaoda) - c90c5e9 linter/no-unused-vars: Simplify checking self call usage (#11281) (Dunqing) ### Documentation - eae51ca linter: Clarify jsdoc/check-tag-names configuration (#11394) (Rägnar O'ock) - cd354d4 oxlint: Remove incorrect doc comment (#11326) (camc314) ### Refactor - 42738f0 linter: Shorten code of match arms (#11389) (Ulrich Stark) - 8a34447 linter: Improve `unicorn/text-encoding-identifier-case` (#11386) (shulaoda) - eaa605e linter: Avoid some `Arc::clone` in linter runtime (#11388) (Boshen) - 1cd8b9c linter: Fixes in `react/forward-ref-uses-ref` are suggestions (#11376) (Sysix) - 50ef691 linter: Add `diagnostics_with_multiple_fixes` to `LintContext` (#11357) (Sysix) - 606bb34 linter: Accept `PossibleFixes` instead of `Fix` for `Messages` (#11295) (Sysix) - 042a3f3 linter: Use `PossibleFixes` instead of `Option<Fix>` (#11284) (Sysix) - ffcfb46 linter: Improve `unicorn/throw-new-error` (#11364) (shulaoda) - 8fb55c3 linter: Cleanup docs and simplify code of `eslint/no-fallthrough` (#11331) (Ulrich Stark) - e2f0f0a linter: Improve docs and simplify code of `eslint/no-duplicate-imports` (#11320) (Ulrich Stark) - b53b053 linter: Simplify accessing span of NameSpan (#11305) (Ulrich Stark) - 4bc2650 linter: Improve `eslint/no-void` (#11285) (shulaoda) ### Styling - 49b664c linter: Remove needless newline in `declare_oxc_lint` (#11400) (camc314) ### Testing - c4f64aa linter: Explicitly disable correctness for clarity (#11327) (camc314) - a404b2c linter: `eslint/no-duplicate-imports` shouldn't report the same span (#11324) (Ulrich Stark) Co-authored-by: camc314 <[email protected]>

github-actions bot added A-linter Area - Linter A-cli Area - CLI labels May 29, 2025

github-actions bot added the C-bug Category - Bug label May 29, 2025

camc314 mentioned this pull request May 29, 2025

fix(linter): remove use of FrameworkFlags::React to decide whether rules should run #11383

Merged

camc314 requested review from Boshen and Sysix May 29, 2025 22:36

camc314 marked this pull request as ready for review May 29, 2025 22:36

camc314 force-pushed the c/05-29-fix_linter_remove_react_from_default_plugin_set branch from de1053f to 8b77451 Compare May 29, 2025 22:38

Sysix approved these changes May 30, 2025

View reviewed changes

camc314 added the 0-merge Merge with Graphite Merge Queue label May 30, 2025

graphite-app bot force-pushed the c/05-29-fix_linter_remove_react_from_default_plugin_set branch from 8b77451 to ead5309 Compare May 30, 2025 07:46

graphite-app bot merged commit ead5309 into main May 30, 2025
23 checks passed

graphite-app bot deleted the c/05-29-fix_linter_remove_react_from_default_plugin_set branch May 30, 2025 07:52

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 30, 2025

oxc-bot mentioned this pull request May 30, 2025

release(oxlint): v0.17.0 #11402

Merged

camc314 mentioned this pull request Jun 23, 2025

linter: react/exhaustive-deps false negative regression #11871

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(linter)!: remove react from default plugin set #11382

fix(linter)!: remove react from default plugin set #11382

Uh oh!

camc314 commented May 29, 2025 •

edited

Loading

Uh oh!

camc314 commented May 29, 2025

Uh oh!

codspeed-hq bot commented May 29, 2025 •

edited

Loading

Uh oh!

camc314 commented May 30, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Uh oh!

	fn should_run(&self, ctx: &ContextHost) -> bool {
	ctx.frameworks().contains(FrameworkFlags::React)
	}

Uh oh!

fix(linter)!: remove react from default plugin set #11382

fix(linter)!: remove react from default plugin set #11382

Uh oh!

Conversation

camc314 commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camc314 commented May 29, 2025

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #11382 will not alter performance

Summary

Uh oh!

camc314 commented May 30, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Uh oh!

camc314 commented May 29, 2025 •

edited

Loading

codspeed-hq bot commented May 29, 2025 •

edited

Loading

camc314 commented May 30, 2025 •

edited by graphite-app bot

Loading