-
Notifications
You must be signed in to change notification settings - Fork 48
Validate vers
qualifier
#186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@jaimergp Thanks! can you add a few simple unit tests? |
@pombredanne, done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The The solution is to add type hints to |
…; branch 'main' of github.com:package-url/packageurl-python into validate-vers
As discussed in today's meeting with @pombredanne, I added aboutcode-org/univers#159 to tame the CI here, which is the simplest PR possible to fix this and let mypy infer things in |
Goes with package-url/purl-spec#433