Skip to content

Validate vers qualifier #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

jaimergp
Copy link
Contributor

@pombredanne
Copy link
Member

@jaimergp Thanks! can you add a few simple unit tests?

@jaimergp
Copy link
Contributor Author

jaimergp commented May 8, 2025

@pombredanne, done!

mprpic
mprpic previously approved these changes May 14, 2025
Copy link

@mprpic mprpic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jaimergp
Copy link
Contributor Author

The mypy errors are external to this PR. We are now importing univers, which doesn't feature the py.typed marker file, so mypy complains it won't infer types from that package.

The solution is to add type hints to universe or ignore the import here. Thoughts @pombredanne @mprpic?

…; branch 'main' of github.com:package-url/packageurl-python into validate-vers
@jaimergp
Copy link
Contributor Author

As discussed in today's meeting with @pombredanne, I added aboutcode-org/univers#159 to tame the CI here, which is the simplest PR possible to fix this and let mypy infer things in univers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants