Skip to content

Improve one line scope #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2016
Merged

Improve one line scope #373

merged 1 commit into from
Apr 20, 2016

Conversation

bounceme
Copy link
Collaborator

#293

this will detect the start and end parentheses after 'if,for,while',allowing statements with parentheses to come after the condition parens.This regex can detect with up to 4 levels of nesting.

pangloss#293
this will detect the start and end parentheses,allowing statements with parentheses to come after the condition parens.This regex can detect with up to 4 levels of nesting.
@bounceme
Copy link
Collaborator Author

A random example were you can see the improvements
https://raw.githubusercontent.com/maxogden/electron-spawn/master/cli.js

@amadeus
Copy link
Collaborator

amadeus commented Apr 13, 2016

I haven't had a chance to test this, but I assume you've been testing it yourself? I am fine to merge it in if no other maintainers object.

@bounceme
Copy link
Collaborator Author

Yes, i haven't seen any issues either with performance or any bugs, if none of the other maintainers have any suggestions for changes to it I think it can atlas make it into develop

@amadeus amadeus merged commit d388b88 into pangloss:develop Apr 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants