Skip to content

spanning multiple lines detection #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2016
Merged

Conversation

bounceme
Copy link
Collaborator

here are the effects, I made sure performance wasn't affected.
Also this has nothing to do with the operators this just illustrates the problem


if ( a == b
    && c == d
    && e == f
    || g == h
    || i == j ) {
  a = b
    + c
    - d;
}

as opposed to this which would indent everything following it:


if ( a == b
    && c == d
    && e == f
    || g == h
    || i == j ) {
  a = b
    + c
    - d;
    }

@davidchambers
Copy link
Collaborator

I'm excited by all the recent activity on this project. I'm sorry I'm unable to review this code, @bounceme.

@amadeus
Copy link
Collaborator

amadeus commented Apr 21, 2016

Honestly, since this is the develop branch, and none of us really know the indent stuff well, I am good with just getting this merged, and testing it over the next couple days. We can always revert, etc.

@bounceme
Copy link
Collaborator Author

we can merge it I just want to fix one more thing so I don't need to make another pr.I'll get it finished tonight or tomorrow hopefully

if ( a == b
    && c == d
    && e == f
    || g == h
    || i == j ) {
  a = b
    + c
    - d;}

this won't return to the if's indent

@amadeus
Copy link
Collaborator

amadeus commented Apr 21, 2016

Sounds good, I'll wait

@bounceme
Copy link
Collaborator Author

Having weird effects with this, maybe i'll reopen if I can figure out what is happening

@bounceme bounceme closed this Apr 21, 2016
@bounceme bounceme reopened this Apr 22, 2016
@bounceme
Copy link
Collaborator Author

I'll squash these commits now,everything seems to work:

for (var j = lowerIndex; j <= upperIndex; ++j) {
  if (Point.leftOn(poly.at(i - 1), poly.at(i), poly.at(j))
      && Point.rightOn(poly.at(i + 1), poly.at(i), poly.at(j))) {
    d = Point.sqdist(poly.at(i), poly.at(j));
    if (d < closestDist) {
      closestDist = d;
      closestIndex = j % this.vertices.length;
    }
  }
}

In progress but here are the effects so far
```

if ( a == b
    && c == d
    && e == f
    || g == h
    || i == j ) {
  a = b
    + c
    - d;
}
```
as opposed to this which would indent everything following it:
```

if ( a == b
    && c == d
    && e == f
    || g == h
    || i == j ) {
  a = b
    + c
    - d;
    }
```
@amadeus amadeus merged commit e9f6a4d into pangloss:develop Apr 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants