-
Notifications
You must be signed in to change notification settings - Fork 352
JS Flow Annotation Support and A Proper Plugin System #470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d532374
to
9dae81b
Compare
I've finally gotten around to adding a proper way for us to have plugins. This particular PR adds plugins for Flow, NGDocs and JSDocs. I could probably still refine how this all works, for example there's a dependency issue where NGDocs is dependent on JSDocs, so I'll still need to come up with a system to standardize those dependencies. |
This is by no means complete, and so far has only been to fix major syntax highlighting issues I've found.
Also linked jsFlowNoise to Noise
Fixes #288
syntax include has a sort of sugar to it that forces all sourced highlighting to be contained, this will break certain more general highlighting for jsFlow. runtime on the other hand, works exactly as you'd expect.
* JSDocs are now hidden behind a variable for consistency with other plugins * NGDoc plugin can now only be enabled if JSDoc is enabled. * Added README documentation for the new global booleans
how about setting the jsdoc variable in the ngdoc file?then users won't need to explicitly define it basically : see if variable is set; if it isn't then source the jsdoc file |
Not sure I follow? NGDocs just add a few things to the existing JSDoc syntax. I don't think they should necessarily be on for JSDocs since they are very angular specific? Furthermore, if there are additional things people would like to add to NGDocs, then they could be added to that respective file. |
What I was thinking is basically just adding a vimscript |
I have begun work on JS Flow annotation support. This is a PR/Branch where it's currently on by default, however when this eventually gets merged, it should be hidden behind a global boolean, and perhaps even sourced from another file completely so as not to clutter up the main syntax file.
This is the test file I am using for it:
I could probably use more test examples. Any of you who use JS Flow should please check out this branch and help test it!
Here's a screenshot of what JS Flow support currently looks like: