-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Typescript does not allow null for style parameter in rect() #3034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I agree. Could you prepare a pull request? Also change the other shape methods accordingly. Tip: when switching to |
using the advancedAPI still doesn't seam to resolve the issue with clipping, I have been trying
I don't have time at the moment to go through and fix the other shape methods and create the tests etc... I am not familiar with the code base |
Is this fix going to make it in index.d.ts? |
If someone from the community creates a pull request, yes. I currently don't have the time to fix this myself. |
when trying to create a clipping rectangle using rect(x, y, w, h, style) with style = null
typescript definition is showing null as an invalid argument option
using
rect(x, y, w, h)
orrect(x, y, w, h, undefined)
does not create the proper clipping rectanglechanging line 722 in jsPDF/types/index.d.ts seams to work
from:
rect(x: number, y: number, w: number, h: number, style?: string): jsPDF;
to:
rect(x: number, y: number, w: number, h: number, style?: string | null ): jsPDF;
The text was updated successfully, but these errors were encountered: