feat: Remove CoreManager SERVER_AUTH_TYPE and SERVER_AUTH_TOKEN infavor of REQUEST_HEADERS

[dplewis]

Pull Request

• Report security issues confidentially.
• Any contribution is under this license.
• Link this pull request to an issue.

Issue

This is a breaking change

Closes: #2551

Approach

No longer need for these global headers as REQUEST_HEADERS does the same thing

Tasks

• Add tests
• Add changes to documentation (guides, repository pages, code comments)

Summary by CodeRabbit

• Bug Fixes

  • Removed support for setting and retrieving server authentication type and token from the user-facing API.
  • The Authorization header is no longer automatically included in API requests based on previously stored authentication values.

• Tests

  • Removed tests related to server authentication type and token handling.

[parse-github-assistant]

🚀 Thanks for opening this pull request!

[coderabbitai]

📝 Walkthrough

"""

Walkthrough

The changes remove support for the SERVER_AUTH_TYPE and SERVER_AUTH_TOKEN configuration options from the codebase. This includes deleting related configuration properties, static accessors in the Parse object, conditional header logic in RESTController, and associated tests.

Changes

File(s)	Change Summary
src/CoreManager.ts	Removed SERVER_AUTH_TYPE and SERVER_AUTH_TOKEN properties from the config object.
src/Parse.ts	Removed static getter/setter properties serverAuthType and serverAuthToken from the Parse object.
src/RESTController.ts	Removed logic that conditionally adds an Authorization header based on CoreManager auth configs.
src/tests/Parse-test.js, src/tests/RESTController-test.js	Deleted tests related to setting/getting and using SERVER_AUTH_TYPE and SERVER_AUTH_TOKEN.
types/Parse.d.ts	Removed static property declarations serverAuthType and serverAuthToken from Parse type definition.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant RESTController
    participant CoreManager

    Client->>RESTController: Make AJAX request
    RESTController->>CoreManager: (No longer queries SERVER_AUTH_TYPE/TOKEN)
    RESTController->>RESTController: Add headers (excluding Authorization)
    RESTController->>Client: Return response

Loading

Assessment against linked issues

Objective	Addressed	Explanation
Remove CoreManager SERVER_AUTH_TYPE and SERVER_AUTH_TOKEN configs (#2551)	✅
Remove use of these configs for Authorization header in RESTController (#2551)	✅
Remove Parse static accessors for server auth type/token (#2551)	✅
Remove related tests for these configs and their usage (#2551)	✅

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes were found.
"""

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d26fe9c and 021a54b.

📒 Files selected for processing (1)

• types/Parse.d.ts (0 hunks)

💤 Files with no reviewable changes (1)

• types/Parse.d.ts

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: build (Node 22, 22.4.1)
• GitHub Check: build (Node 18, 18.20.4)
• GitHub Check: build (Node 20, 20.15.1)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[parseplatformorg]

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8bedabd) to head (021a54b).

Additional details and impacted files

@@            Coverage Diff            @@
##             alpha     #2639   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        63           
  Lines         6193      6183   -10     
  Branches      1472      1471    -1     
=========================================
- Hits          6193      6183   -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.