Skip to content

chore: defining the latest LTS Node version as the minimum #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 27, 2022

Conversation

mfranzke
Copy link
Contributor

@mfranzke mfranzke commented Dec 22, 2022

Summary of changes:

We should update to the latest Node 14 version.

Prerequisite for non-crashing piplines: #1444

@mfranzke mfranzke self-assigned this Dec 22, 2022
@mfranzke mfranzke requested a review from sghoweri as a code owner December 22, 2022 15:08
@mfranzke mfranzke marked this pull request as draft December 22, 2022 15:16
to make any minor or patch updates obsolete
@mfranzke mfranzke marked this pull request as ready for review December 24, 2022 12:58
JosefBredereck
JosefBredereck previously approved these changes Dec 27, 2022
@mfranzke mfranzke marked this pull request as draft December 27, 2022 21:20
@mfranzke
Copy link
Contributor Author

we sadly get an error in the pipeline output:

error @pattern-lab/[email protected]: The engine "node" is incompatible with this module. Expected version ">=14.21.2". Got "14.21.1"

@mfranzke mfranzke marked this pull request as ready for review December 27, 2022 21:26
@mfranzke
Copy link
Contributor Author

we sadly get an error in the pipeline output:

error @pattern-lab/[email protected]: The engine "node" is incompatible with this module. Expected version ">=14.21.2". Got "14.21.1"

this one seems to be fixed.

@JosefBredereck JosefBredereck merged commit 773909d into pattern-lab:dev Dec 27, 2022
@mfranzke mfranzke deleted the refactor/update-node-version branch December 27, 2022 21:57
antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this pull request Apr 12, 2023
…ab#1445)

* chore: defining the latest node version as the minimum

* refactor: pinning to major version even only

to make any minor or patch updates obsolete

* Revert "refactor: pinning to major version even only"

This reverts commit c9cc223.

* Update ISSUE_TEMPLATE.md

* chore: we need to be a little bit more flexible on the expected Node patch version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants