Skip to content

Chart - simplify skeleton theme #10346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dlabrecq opened this issue May 8, 2024 · 0 comments · Fixed by #10348
Closed

Chart - simplify skeleton theme #10346

dlabrecq opened this issue May 8, 2024 · 0 comments · Fixed by #10348
Assignees
@dlabrecq

Comments

@dlabrecq
Copy link
Member

dlabrecq commented May 8, 2024 •
edited
Loading

Refactor skeleton theme to a more simplified implementation. For example, component properties (i.e., skeleton label props) should be omitted from what's being passed through to Victory charts. The base theme should only contain Victory supported properties.
@dlabrecq dlabrecq added the bug label May 8, 2024
@dlabrecq dlabrecq self-assigned this May 8, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues May 8, 2024
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue May 8, 2024
@dlabrecq
chore(charts): refactor how skeleton theme is applied
7bc2fad 
patternfly#10346
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue May 8, 2024
@dlabrecq
chore(charts): refactor how skeleton theme is applied
0efcae1 
patternfly#10346
@dlabrecq dlabrecq mentioned this issue May 8, 2024
Merged
dlabrecq added a commit that referenced this issue May 14, 2024
@dlabrecq
chore(charts): refactor how skeleton theme is applied (#10348)
85f2be1 
* chore(charts): refactor how skeleton theme is applied

#10346

* chore(charts): marked obsolete, private functions as deprecated
@github-project-automation github-project-automation bot moved this from Needs triage to Done in PatternFly Issues May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dlabrecq dlabrecq

Labels
None yet
Projects
PatternFly Issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(charts): refactor how skeleton theme is applied dlabrecq/patternfly-react
1 participant
@dlabrecq