Skip to content

Bug - Card - Cannot deselect a clickable card #9875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jschuler opened this issue Dec 11, 2023 · 0 comments · Fixed by #10168 or #10202
Closed

Bug - Card - Cannot deselect a clickable card #9875

jschuler opened this issue Dec 11, 2023 · 0 comments · Fixed by #10168 or #10202
Assignees
@thatblindgeye
Milestone
2024.Q1

Comments

@jschuler
Copy link
Collaborator

Describe the problem
I'd like to be able to deselect an active card. Essentially similar to this deprecated example: https://www.patternfly.org/components/card/#selectable-card-accessibility-features-deprecated

How do you reproduce the problem?
[Provide steps to reproduce. A codesandbox demonstrating the problem is appreciated.](https://codesandbox.io/p/sandbox/staging-thunder-xd5qhs?file=%2FCard.tsx)
@jschuler jschuler added the bug label Dec 11, 2023
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Dec 11, 2023
@tlabaj tlabaj moved this from Needs triage to Backlog in PatternFly Issues Dec 13, 2023
@tlabaj tlabaj added this to the Prioritized Backlog milestone Dec 13, 2023
@ezr-ondrej ezr-ondrej mentioned this issue Mar 7, 2024
Closed
@wise-king-sullyman wise-king-sullyman moved this from Backlog to Not started in PatternFly Issues Mar 7, 2024
@thatblindgeye thatblindgeye moved this from Not started to In Progress in PatternFly Issues Mar 15, 2024
@thatblindgeye thatblindgeye mentioned this issue Mar 15, 2024
Merged
@thatblindgeye thatblindgeye linked a pull request Mar 18, 2024 that will close this issue
fix(Card): updated logic to prevent unclickable cards #10168
Merged
@thatblindgeye thatblindgeye moved this from In Progress to PR Review in PatternFly Issues Mar 25, 2024
@thatblindgeye thatblindgeye mentioned this issue Mar 26, 2024
Merged
@thatblindgeye thatblindgeye linked a pull request Mar 27, 2024 that will close this issue
fix(Card): updated v5 logic to prevent unclickable cards #10202
Merged
@amirfefer amirfefer mentioned this issue Mar 28, 2024
Merged
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thatblindgeye thatblindgeye

Labels
None yet
Projects
PatternFly Issues
Archived in project
Milestone
2024.Q1
4 participants
@jschuler @wise-king-sullyman @tlabaj @thatblindgeye