Skip to content

chore: fix types for number input #10264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

jonkoops
Copy link
Contributor

@jonkoops jonkoops commented Apr 9, 2024

Refactors the types of the number input so that they will compile when upgrading to TypeScript 5. This is needed to land #10156.

@patternfly-build
Copy link
Contributor

patternfly-build commented Apr 9, 2024

Copy link
Contributor

@mfrances17 mfrances17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mfrances17 mfrances17 requested a review from tlabaj April 15, 2024 20:10
@tlabaj tlabaj merged commit 4b75c6e into patternfly:main Apr 19, 2024
@patternfly-build
Copy link
Contributor

Your changes have been released in:

Thanks for your contribution! 🎉

@jonkoops jonkoops deleted the fix-types-number-input branch April 20, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants