Skip to content

fix(FileUploadField): Allow browse button disable #11476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 24, 2025
Merged

fix(FileUploadField): Allow browse button disable #11476

merged 2 commits into from
Jan 24, 2025

Conversation

mfrances17
Copy link
Contributor

What: Closes #10830

@mfrances17 mfrances17 requested a review from a team January 23, 2025 23:28
@mfrances17 mfrances17 self-assigned this Jan 23, 2025
@mfrances17 mfrances17 requested review from tlabaj and kmcfaul and removed request for a team January 23, 2025 23:28
@patternfly-build
Copy link
Contributor

patternfly-build commented Jan 23, 2025 •
edited
Loading

Preview: https://patternfly-react-pr-11476.surge.sh

A11y report: https://patternfly-react-pr-11476-a11y.surge.sh

thatblindgeye
thatblindgeye requested changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Can we just add a test that checks the new prop disabled the button as expected? This is a component that looks to still need some updates to their tests, but would be nice to get some of these tests sprinkled in as new things are added.

kmcfaul
kmcfaul approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@kmcfaul kmcfaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for the code, I agree some tests would be a nice to have but could be a follow up

@mfrances17 mfrances17 force-pushed the fileupload-browse-disable branch from 50a6df6 to 23db09c Compare January 24, 2025 21:10
@mfrances17
Copy link
Contributor Author

Added a couple of tests

@thatblindgeye thatblindgeye merged commit 0d31dcd into patternfly:main Jan 24, 2025
13 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

Thanks for your contribution! 🎉

mattnolting pushed a commit to mattnolting/patternfly-react that referenced this pull request Feb 14, 2025
@mfrances17 @mattnolting
fix(FileUploadField): Allow browse button disable (patternfly#11476)
a4f6ac3 
* fix(FileUploadField): Allow browse button disable

* add tests for browse button disable
@thatblindgeye thatblindgeye mentioned this pull request Mar 19, 2025
Merged
@renovate renovate bot mentioned this pull request Jun 1, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmcfaul kmcfaul kmcfaul approved these changes

@thatblindgeye thatblindgeye thatblindgeye approved these changes

@tlabaj tlabaj Awaiting requested review from tlabaj tlabaj was automatically assigned from patternfly/react-reviewers

Assignees

@mfrances17 mfrances17

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug - [FileUploadField] - cannot control individual disablement of browse button
4 participants
@mfrances17 @patternfly-build @kmcfaul @thatblindgeye