chore(React 19): removed additional deprecations #11538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-11538.surge.sh A11y report: https://patternfly-react-pr-11538-a11y.surge.sh |
thatblindgeye
requested review from
a team,
mfrances17 and
kmcfaul
and removed request for
a team
mfrances17
requested changes
Feb 18, 2025
There was a problem hiding this comment.
This looks good... i'm questioning whether we still need /static in react-docs. The info in here looks stale and outdated, and refers to PropTypes in the text. I haven't been able to find how to even get to it from the docs, so it seems inaccessible and maybe we can just remove it entirely? Otherwise it's a 👍 from me.
kmcfaul
approved these changes
Feb 20, 2025
thatblindgeye
force-pushed
the
removePropTypes
branch
from
901ffaf to
54b0a42
Compare
mfrances17
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #11367, closes #11366, closes #11364, closes #11363, closes #11362
Note that most of these issues can be considered resolved by the removal of the MockedTableChanges file (which wasn't being used anywhere from what I can tell).
Additional issues: