Skip to content

chore(Password demos): moved to Patterns #11539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

thatblindgeye
Copy link
Contributor

What: Closes #10105

Additional issues:

@thatblindgeye thatblindgeye requested review from a team, mfrances17 and kmcfaul and removed request for a team February 17, 2025 16:05
@patternfly-build
Copy link
Contributor

patternfly-build commented Feb 17, 2025

Copy link
Contributor

@mfrances17 mfrances17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes are good 👍

i realize this is tangential to the proposed changes, but in the example, i would expect type="text" on ln 105 to be type="password" to be more realistic - what do you think?

@thatblindgeye
Copy link
Contributor Author

i realize this is tangential to the proposed changes, but in the example, i would expect type="text" on ln 105 to be type="password" to be more realistic - what do you think?

Good catch, since we're in here I went ahead and made that update

@mfrances17 mfrances17 merged commit 7fb9ea7 into patternfly:main Feb 20, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password strength + generator demos docs location
4 participants