Skip to content

feat(ClipboardCopy): added truncation for inlinecompact variant #11610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

thatblindgeye
Copy link
Contributor

What: Closes #10890

Additional issues:

@thatblindgeye thatblindgeye requested review from a team, mfrances17, tlabaj, gitdallas and christianvogt and removed request for a team March 5, 2025 19:42
@patternfly-build
Copy link
Contributor

patternfly-build commented Mar 5, 2025

@gitdallas
Copy link
Contributor

played around a little with the truncate props there
image

Copy link
Contributor

@gitdallas gitdallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, i wonder if we can make sure that the icon is inline with the text? seems like it is always going to the next level:
image

@thatblindgeye thatblindgeye force-pushed the iss10890_clipboardTruncate branch from 7e8e6d3 to db7d624 Compare March 11, 2025 20:07
@thatblindgeye thatblindgeye force-pushed the iss10890_clipboardTruncate branch from db7d624 to 96a3823 Compare March 12, 2025 15:54
Copy link
Contributor

@gitdallas gitdallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now, thanks 🚀

image

@wise-king-sullyman wise-king-sullyman merged commit 48b5749 into patternfly:main Mar 12, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClipboardCopy - Allow truncate flexibility
6 participants