Sankey chart (1 of 2) #11616
Merged
Sankey chart (1 of 2) #11616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-11616.surge.sh A11y report: https://patternfly-react-pr-11616-a11y.surge.sh |
dlabrecq
force-pushed
the
sankey
branch
3 times, most recently
from
1eef77e to
9f62631
Compare
Closed
thatblindgeye
requested review from
a team and
mmenestr
and removed request for
a team
thatblindgeye
requested review from
a team,
lboehling and
bekah-stephens
and removed request for
a team
lboehling
approved these changes
Mar 11, 2025
dlabrecq
force-pushed
the
sankey
branch
2 times, most recently
from
b7a3117 to
2f80d5c
Compare
| @@ -0,0 +1 @@ | |||
| ../../../Charts | |||
There was a problem hiding this comment.
Just curious: what's this file doing?
There was a problem hiding this comment.
This is a soft link for docs. Specifically, so the build can find ChartsDoc for the "React next" example.
There was a problem hiding this comment.
Removing it locally doesn't seem to change the next line examples from what I can tell 🤔
There was a problem hiding this comment.
Removed the soft link. I discovered how to use a relative path with propComponents
dlabrecq
force-pushed
the
sankey
branch
2 times, most recently
from
9bf5623 to
1f84f4f
Compare
wise-king-sullyman
approved these changes
Mar 14, 2025
dlabrecq
force-pushed
the
sankey
branch
10 times, most recently
from
6f3e235 to
778a5fd
Compare
nicolethoen
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created
SankeyandLinecharts, based on Apache ECharts.Note the
Linechart was added to help nail-down some boilerplate features such as theme colors and properties, custom legend tooltips, and skeletons. This should make it easier to add more ECharts (e.g.,Bar) in the future.Sankey chart (2 of 2): #11622 (doc updates only)
Closes: #10817