Skip to content

chore(readme): fixed broken link for react tokens #11654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2025

Conversation

Mash707
Copy link
Contributor

@Mash707 Mash707 commented Mar 12, 2025

Closes #11645

@patternfly-build
Copy link
Contributor

patternfly-build commented Mar 12, 2025

@thatblindgeye thatblindgeye requested a review from tlabaj March 12, 2025 12:11
@thatblindgeye
Copy link
Contributor

@tlabaj can you confirm if the link is correct or if you had meant another page?

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should update the link to say "All PatternFly tokens"
and the link should be to this page. https://www.patternfly.org/tokens/all-patternfly-tokens

@Mash707 Mash707 requested a review from tlabaj March 12, 2025 17:27
@tlabaj tlabaj merged commit debf928 into patternfly:main Mar 12, 2025
13 checks passed
@Mash707 Mash707 deleted the update-react-tokens-link branch March 12, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - broken link in react-tokens readme
4 participants