Skip to content

Remove duplicated mocking #13151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Conversation

ivojawer
Copy link
Contributor

fixes #12056

Removes duplicated code and uses trait

@welcome
Copy link

welcome bot commented Mar 26, 2023

Thanks for opening this pull request! Now continious integration (CI) will build Pharo with your change and run all tests. This might fail due to many reasons! Please check if your PR breaks the build or makes tests fail. Feel free to add comments to the PR. After this, before your PR can be merged it needs one or more reviews. Do not hesitate to ask people (on the Mailinglist or Discord) to help! When the CI shows no problems and there are positive reviews, your PR will be merged.

@MarcusDenker MarcusDenker changed the base branch from Pharo11 to Pharo12 March 27, 2023 08:13
@MarcusDenker
Copy link
Member

Thanks for the PR!

I have moved it to Pharo12, as we are in freeze mode for Pharo11 (which means only bugs should get fixed).

@welcome
Copy link

welcome bot commented Mar 27, 2023

Congrats on merging your first pull request! Do another one! We try to have a list of (relatively) easy issues here: https://github.com/orgs/pharo-project/projects/8.

GitHub
GitHub is where people build software. More than 100 million people use GitHub to discover, fork, and contribute to over 330 million projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleaning old class definition in RB
4 participants