Skip to content

fix: delete without condition if cache disabled #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
Merged

fix: delete without condition if cache disabled #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/cache/CacheHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,16 @@ class CacheHandler implements CacheHandlerContract
* Cache policies for the given model.
*
* @param Rule $model The model to cache policies for.
* @return Query The cached query or a new query if caching is disabled.
* @return Query|Rule The cached query if caching is disabled, or origin Rule.
*/
public function cachePolicies(Rule $model): Query
public function cachePolicies(Rule $model): Query|Rule
{
if ($this->config('cache.enabled', false)) {
$key = $this->config('cache.key', 'tauthz');
$expire = $this->config('cache.expire', 0);
return $model->cache($key, $expire);
} else {
return $model->newQuery();
return $model;
}
}
}
2 changes: 1 addition & 1 deletion src/cache/CacheHandlerContract.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@

interface CacheHandlerContract
{
public function cachePolicies(Rule $model): Query;
public function cachePolicies(Rule $model): Query|Rule;
}