feat: Make serializer configurable via YAML configuration #1390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add support for configuring serializers through YAML in RdKafkaContext - Allow serializer specification as a class name, array with options, or instance
Steveb-p
reviewed
May 20, 2025
- Ensures robustness by providing a default serializer - Refactoring
Steveb-p
approved these changes
May 26, 2025
Comment on lines
+182
to
+185
| /** | ||
| * @return void | ||
| * JsonSerializer should be the default fallback if no serializer is specified | ||
| */ |
There was a problem hiding this comment.
No need to re-specify the return type, since it's already present in the PHP declaration.
As for the description, I'm not sure it's worthwile - but nothing against it either.
Suggested change
| /** | |
| * @return void | |
| * JsonSerializer should be the default fallback if no serializer is specified | |
| */ | |
| /** | |
| * JsonSerializer is the default fallback, if no serializer is specified. | |
| */ |
| @@ -36,6 +36,34 @@ public function testShouldSetJsonSerializerInConstructor() | |||
| $this->assertInstanceOf(JsonSerializer::class, $context->getSerializer()); | |||
| } | |||
|
|
|||
| public function testShouldUseStringSerializerClassFromConfig() | |||
There was a problem hiding this comment.
Consider adding unit test that checks assertSame instance when serializer object is passed. If you are able you might want to check constructor options with method call assertions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables users to specify custom serializers with configuration
options in their Enqueue bundle YAML configuration, improving flexibility
when working with different message formats.