Skip to content

Fix compatibility with PHP 8.0 #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Nov 2, 2020
Merged

Fix compatibility with PHP 8.0 #740

merged 12 commits into from
Nov 2, 2020

Conversation

ausi
Copy link
Collaborator

@ausi ausi commented Sep 13, 2020

In PHP 8.0 the GD resources got replaced with GdImage objects, see php/php-src@8aad466

@ausi
Copy link
Collaborator Author

ausi commented Sep 13, 2020

It looks like the nightly build doesn’t run through https://travis-ci.org/github/avalanche123/Imagine/jobs/726730923
I don’t know how to fix this.

This was referenced Sep 13, 2020
Closed
Merged
@mlocati
Copy link
Collaborator

mlocati commented Sep 14, 2020

I fixed the compilation of the imagick PHP extension, but it seems that gmagick extension is not ready for PHP 8 (see https://pecl.php.net/package/gmagick and http://svn.php.net/viewvc/pecl/gmagick )

@mlocati
Copy link
Collaborator

mlocati commented Sep 14, 2020

PS: for gmagick I submitted this bug report.

ausi
ausi commented Sep 15, 2020
View reviewed changes
ausi
ausi commented Sep 15, 2020
View reviewed changes
@ausi
Copy link
Collaborator Author

ausi commented Sep 15, 2020

Besides the GMagick error and the incompatible dev-dependencies PHP 8.0 compatibility should be OK with this pull request I think.

@ausi
Copy link
Collaborator Author

ausi commented Oct 19, 2020

It looks like there is not much activity in GMagick (see vitoc/gmagick#48 ).

@mlocati should we merge this as it is now to have at least GD and IMagick support for PHP 8.0?

@ausi ausi marked this pull request as ready for review October 19, 2020 15:34
derrabus
derrabus suggested changes Nov 2, 2020
View reviewed changes
Copy link

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this issue. ❤️

I'm using this library in an application that I'd like to test with php 8. Merging at least the fix for the GD incompatibilities would really help me out.

@ausi
Copy link
Collaborator Author

ausi commented Nov 2, 2020

Merging at least the fix for the GD incompatibilities would really help me out.

That’s pretty much everything this PR does. There don’t seem to be any other incompatibilities with PHP 8.0.

The planned release date for PHP 8.0 is less than a month away, so I think it would be a good time to merge this PR ☺️

@mlocati mlocati merged commit e52f43e into php-imagine:develop Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus requested changes

@mlocati mlocati mlocati approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ausi @mlocati @derrabus