Try-catch in Imagine\Gmagick\Effects::convolve should catch GmagickException instead of ImagickException #757
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main reason of this pull-request is 1), it is small bugfix.
I know that tests wanted, but I'm not sure that it is required in such case because looks like its copy-paste mistake.
I tested code using the following test:
in \Imagine\Test\Gmagick\EffectsTest add
then run
Image is too small and it leads to exception. At least for
gmagick version 2.0.4RC1
GraphicsMagick version GraphicsMagick 1.3.28 2018-01-20 Q16
I'm not sure about other versions. But if gmagick will throw an exception it should be GmagickException.