Skip to content

Add $because to rules builder #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2024
Merged

Add $because to rules builder #411

merged 1 commit into from
May 8, 2024

Conversation

hgraca
Copy link
Contributor

@hgraca hgraca commented Sep 18, 2023

This will allow the output to be more expressive

marmichalski
marmichalski approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@marmichalski marmichalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM might want to update (or add a new) one of the ArchitectureTest to verify that the argument string is indeed being used 👍

AlessandroMinoccheri
AlessandroMinoccheri approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@AlessandroMinoccheri AlessandroMinoccheri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlessandroMinoccheri AlessandroMinoccheri merged commit 43653b9 into phparkitect:main May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlessandroMinoccheri AlessandroMinoccheri AlessandroMinoccheri approved these changes

@marmichalski marmichalski marmichalski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hgraca @AlessandroMinoccheri @marmichalski