Add compatibility with phpstan/phpdoc-parser v2 #442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build pipeline is fixed so by rebasing to master you should be able to get all the checks passing. |
|
@EmilMassey I guess we can just drop the support to version 1, would you mind updating the PR? Thank you! |
EmilMassey
force-pushed
the
phpstan-parser-allow-v2
branch
from
1e59286 to
7931644
Compare
EmilMassey
force-pushed
the
phpstan-parser-allow-v2
branch
from
7931644 to
32a5109
Compare
|
While I don't believe any new features in v2 are necessary for this library, updating the dependency allows arkitect to be installed in codebases that need v2 for various reasons. That's the main reason for my PR. I updated the PR and dropped support for v1. |
|
thanks @EmilMassey! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds compatibility for
phpstan/phpdoc-parserv2 while maintaining support for v1.Currently check are failing due to invalid code style: see #443 for the fix.