Fixed false-positive with by-ref parameters and array-functions

[staabm]

closes phpstan/phpstan#13093
closes phpstan/phpstan#8825
closes phpstan/phpstan#7844
closes phpstan/phpstan#12675

[ondrejmirtes]

Maybe the right scope needs to be used also below in more VariableAssignNode instances? Try writing a failing test first.

[ondrejmirtes]

Also:

1. new PropertyAssignNode on line 5630
2. dtto on line 5676
3. dtto on line 5719
4. dtto on line 5750

[ondrejmirtes]

You can look at other new VariableAssignNode and PropertyAssignNode. Maybe there's more.

[staabm]

not sure how to test the ExistingArrayDimFetch variant

phpstan-src/src/Analyser/NodeScopeResolver.php

Lines 5863 to 5875 in d04535d

	if ($var instanceof Variable && is_string($var->name)) {
	$nodeCallback(new VariableAssignNode($var, $assignedPropertyExpr), $scope);
	$scope = $scope->assignVariable($var->name, $valueToWrite, $nativeValueToWrite, TrinaryLogic::createYes());
	} else {
	if ($var instanceof PropertyFetch || $var instanceof StaticPropertyFetch) {
	$nodeCallback(new PropertyAssignNode($var, $assignedPropertyExpr, $isAssignOp), $scope);
	}
	$scope = $scope->assignExpression(
	$var,
	$valueToWrite,
	$nativeValueToWrite,
	);
	}

[ondrejmirtes]

I don't think the expr is processed and scope changed for this one.

[ondrejmirtes]

Looks like quite a few more bugs were fixed! https://github.com/phpstan/phpstan-src/actions/runs/15362052666

[phpstan-bot]

This pull request has been marked as ready for review.

[ondrejmirtes]

Thank you!