Skip to content

Remove unnecessary URL encoding when setting bg image #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2014

Conversation

mrclay
Copy link
Contributor

@mrclay mrclay commented Jul 22, 2014

this.imageSrc is not being set as URI component so this encoding just breaks URLs containing "/" and other common chars. The only URL char you'd would worry about would be ) but that's a) extremely rare in an image URL, and b) would probably be URL encoded by the browser when it read the property.

mikegreiling added a commit that referenced this pull request Jul 22, 2014
Remove unnecessary URL encoding when setting bg image
@mikegreiling mikegreiling merged commit e002524 into pixelcog:master Jul 22, 2014
@mikegreiling
Copy link
Member

Thanks for the pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants