Skip to content

Support multiple transports #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2025
Merged

Support multiple transports #35

merged 1 commit into from
Jun 4, 2025

Conversation

longfin
Copy link
Member

@longfin longfin commented May 26, 2025 •
edited
Loading

Description of Changes

See also #17

This PR makes that the server can serves multiple transports (i.e., streamable-http + SSE), since there're still many clients that support only SSE. (e.g., Cursor)

Type of Change

  • Bug fix
  • New feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • CI-related changes
  • Documentation content changes
  • Other changes

Does this change include dependency updates?

  • Yes
  • No

Testing

Please describe how you tested these changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • All dependent changes have been merged and published

@longfin longfin self-assigned this May 26, 2025
@longfin longfin requested review from jckdotim and michaelKAP-K May 26, 2025 06:09
michaelKAP-K
michaelKAP-K reviewed May 27, 2025
View reviewed changes
Copy link
Collaborator

@michaelKAP-K michaelKAP-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@longfin longfin merged commit 7e85b91 into planetarium:main Jun 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelKAP-K michaelKAP-K michaelKAP-K left review comments

@jckdotim jckdotim Awaiting requested review from jckdotim

Assignees

@longfin longfin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@longfin @michaelKAP-K