Added ref forwarding to Flex and Box #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saitonakamura
force-pushed
the
add-ref
branch
2 times, most recently
from
0a66836 to
db5d3da
Compare
|
Can you please rebase? |
This would with various helpers and hooks that use refs to somehow affect the component, say rotate it or draw a bounding box
saitonakamura
force-pushed
the
add-ref
branch
from
91267ec to
523a04e
Compare
|
@giulioz sure, done |
|
not sure what's with the ci, commands looks fine locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would with various helpers and hooks that use refs to somehow affect the component,
say rotate it or draw a bounding box
My use case is to draw a UI on a plane than rotate it towards the eyesight in vr
Any thoughts against it? One other thing is that because of the additional indent it looks like everthing has changed, but it's not. Maybe we want to extract a top level function we'll pass to React.forwardRef?