Skip to content

Fix docker build script #5670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2021
Merged

Fix docker build script #5670

merged 1 commit into from
Jun 23, 2021

Conversation

sorpaas
Copy link
Contributor

@sorpaas sorpaas commented Jun 23, 2021

The current Dockerfile script doesn't seem to be able to build successfully from the ground up. This PR fixes it:

  • Install ca-certificates. Without it, it seems that every SSL requests would fail -- nodesource can't be fetched, npm can't install.
  • Remove duplicate nodejs and npm package installation. nodejs comes from nodesource which includes the npm executable, and npm comes from Ubuntu. They conflict.

Copy link
Member

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much.

@jacogr jacogr merged commit 24dc5ba into polkadot-js:master Jun 23, 2021
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jun 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants