Skip to content

Accounts page unit testing - base for further dev of accounts #5872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jul 28, 2021

Conversation

wachulski
Copy link
Contributor

This material does not change the behavior/functionality, but adds unit tests + unit testing facilities.

This is a foundation on top of which other PRs related to Accounts features/enhancements are going to be built.

Marcin Wachulski and others added 7 commits July 23, 2021 15:37
Moving ArrangedAccount around
Linking arranged balances values to mocked balances calls.
…-accounts-unit-testing

# Conflicts:
#	packages/page-accounts/test/hooks/default.ts
#	packages/page-accounts/test/pages/accountsPage.tsx
Formatting utils made consistent
@wachulski wachulski marked this pull request as ready for review July 26, 2021 13:27
Copy link
Contributor

@krzysztof-jelski krzysztof-jelski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but perhaps @jacogr would want to have a final look.

@krzysztof-jelski krzysztof-jelski merged commit 809520d into master Jul 28, 2021
@krzysztof-jelski krzysztof-jelski deleted the mw-accounts-unit-testing branch July 28, 2021 09:50
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants