-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Accounts page unit testing - base for further dev of accounts #5872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extraction of useAccounts and useBalance hooks
Extraction of useAccounts and useBalance hooks
Moving ArrangedAccount around
Linking arranged balances values to mocked balances calls.
…-accounts-unit-testing # Conflicts: # packages/page-accounts/test/hooks/default.ts # packages/page-accounts/test/pages/accountsPage.tsx
Formatting utils made consistent
krzysztof-jelski
approved these changes
Jul 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but perhaps @jacogr would want to have a final look.
jacogr
reviewed
Jul 28, 2021
jacogr
reviewed
Jul 28, 2021
jacogr
reviewed
Jul 28, 2021
jacogr
reviewed
Jul 28, 2021
jacogr
reviewed
Jul 28, 2021
jacogr
reviewed
Jul 28, 2021
Co-authored-by: Jaco <[email protected]>
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This material does not change the behavior/functionality, but adds unit tests + unit testing facilities.
This is a foundation on top of which other PRs related to Accounts features/enhancements are going to be built.