Skip to content

Set pbkdf2Encode rounds to default to 210,000 #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Set pbkdf2Encode rounds to default to 210,000 #1983

wants to merge 2 commits into from

Conversation

TarikGul
Copy link
Member

@TarikGul TarikGul commented Apr 13, 2025 •
edited
Loading

BREAKING CHANGE

In line with https://cheatsheetseries.owasp.org/cheatsheets/Password_Storage_Cheat_Sheet.html#pbkdf2 - set the default rounds to 210_000.

Why 210,000?:

We pass in Sha512 for pbkdf2Js from @noble/hashes
By default pbkdf2 from @polkadot/wasm-crypto uses HMAC-SHA512.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TarikGul