Skip to content

Type global APIs: $router and $router, beforeRouteLeave, etc #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
posva opened this issue Jun 27, 2022 · 1 comment
Closed

Type global APIs: $router and $router, beforeRouteLeave, etc #3

posva opened this issue Jun 27, 2022 · 1 comment

Comments

@posva
Copy link
Owner

posva commented Jun 27, 2022 •
edited
Loading

Currently it seems like types are conflicting

Image
@posva posva changed the title Type global $router and $router Type global APIs: $router and $router, beforeRouteLeave, etc Jun 27, 2022
@posva
Copy link
Owner Author

posva commented Jun 29, 2022

Turns out this is because override of types get merged together instead of replaced. So I need to find a way that allows these types to be overriden outside of Vue Router. Maybe introducing a Config interface that can be extended

@posva posva closed this as completed Jun 29, 2022
@posva posva reopened this Jun 29, 2022
@posva posva closed this as completed in 0d87201 Jun 29, 2022
@posva posva moved this from 🔖 Ready to ✅ Done in unplugin-vue-router Jun 29, 2022
zhangmo8 added a commit to zhangmo8/unplugin-vue-router that referenced this issue Aug 5, 2024
@zhangmo8
# This is a combination of 7 commits.
9668fbb 
# This is the 1st commit message:

chore: resolve conflicts

# This is the commit message posva#2:

fix: fix the vue-loader error

# This is the commit message posva#3:

fix: setup return route

# This is the commit message posva#4:

fix: lint fix

# This is the commit message posva#5:

Update examples/webpack/shims-vue.d.ts

Co-authored-by: Eduardo San Martin Morote <[email protected]>
# This is the commit message posva#6:

chore: update webpack deps & lock file

# This is the commit message posva#7:

chore: update webpack deps & lock file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
unplugin-vue-router
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@posva