[Datasource] [Resource] Standardize Arg_CloudInstanceID argument across all data source and resource #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismirlia
changed the title
|
I do not think ForceNew needs to be specified on datasources, we should look into that |
|
ok, so after playing around with it makes sense to only have it in the resources. In the resources you could accidentally update the pi_cloud_instance_id and think that does something. It doesn't technically break anything or at least it doesn't in network resource because the argument for pi_cloud_instance_id is only used in creation and not in update or reading. It just messes up the state if you are relying on that value, so adding force new to pi_cloud_instance_id in that case will force you to recreate the resource in another workspace which is the correct behavior if you are changing that. |
…esource There were a couple of data sources that did not have the validation.NoZeroValues check that is required, and force new was added to the resources. The resources need force new on this argument because a user could accidentally update that field and think it does something when in reality it just messes up the state. Data sources don't need the value because data sources don't do updates.
ismirlia
force-pushed
the
force-new-cloud-instance-id
branch
from
4934717 to
8d105ff
Compare
Alexander-Kita
approved these changes
May 16, 2025
|
Opened IBM-Cloud#6249, closing this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple of data sources that did not have the validation.NoZeroValues check that is required, and force new was added to the resources. The resources need force new on this argument because a user could accidentally update that field and think it does something when in reality it just messes up the state. Data sources don't need the value because data sources don't do updates.