-
Notifications
You must be signed in to change notification settings - Fork 5.5k
[native] Add test for substring alias #25197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yabinma
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yabinma : Please fix the failing tests... Think that is because presto-teradata-functions module is not registered on the Java side. Please can you check.
Got a chance to check today. substring is already registered in presto-teradata-functions, Line 88 in d9f71c4
I was thinking it might be missed in common place, that's why I added another substring registration in com.facebook.presto.operator.scalar.StringFunctions
So the previous "substring is not registered" error might not be caused by function register code. I will check the workflow later how the test server is configured. It might need to add the TeradataStringFunctions registration in the configuration. |
I rollback the code to contain the test case changes only and the workflow returned the same error message that "substring is not registered" It failed in step: prestocpp-linux-presto-e2e-tests: then I checked the workflow code in https://github.com/prestodb/presto/blob/fda51140321fca27f8054786c3ceedd555700cb5/.github/workflows/prestocpp-linux-build-and-unit-test.yml#L93C3-L93C36 The dependency image shown: container: My Velox PR was merged in 20250523. This might be one of the reasons. @aditi-pandit , do you know how frequently the test image is updated? |
Uh oh!
There was an error while loading. Please reload this page.