Skip to content

View and delete jobs functionality in the CLI #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Aug 10, 2023
Merged

View and delete jobs functionality in the CLI #293

merged 13 commits into from
Aug 10, 2023

Conversation

carsonmh
Copy link
Contributor

@carsonmh carsonmh commented Aug 8, 2023

Issue link

closes #277

What changes have been made

Added

  • job status command
  • job cancel command
  • job logs command
  • job list command
  • list_jobs functionality in cli_utils
  • get_job functionality in cli_utils

Verification steps

build SDK with pip install -e . and run any command with codeflare.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@carsonmh carsonmh force-pushed the cli-update branch 2 times, most recently from ffda563 to 18a2aa5 Compare August 8, 2023 22:03
@click.option("--no-ray", is_flag=True)
def job(ctx, cluster_name, namespace, no_ray):
"""
List all jobs in a specified RayCluster or in K8S cluster
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not exactly right. in both cases the jobs are being run on K8s clusters. However, they may be run either through the ray or mcad-kubernetes schedulers. In the ray case there will be a "raycluster" that we can reference to get job info. In the mcad-kubernetes case there is only pods that get deployed (as their own short lived "cluster").

So you may want to change this to just "List all jobs submitted".

@click.pass_context
@click.option("--cluster-name", "-c", type=str)
@click.option("--namespace", "-n", type=str)
@click.option("--no-ray", is_flag=True)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this is --kube-mcad-scheduler-only

@MichaelClifford
Copy link
Collaborator

@carsonmh Can you rebase this PR?

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MichaelClifford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 10, 2023

New changes are detected. LGTM label has been removed.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2023
@MichaelClifford MichaelClifford added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2023
@openshift-merge-robot openshift-merge-robot merged commit 91a46c9 into project-codeflare:cli-update Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants