-
Notifications
You must be signed in to change notification settings - Fork 54
View and delete jobs functionality in the CLI #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
View and delete jobs functionality in the CLI #293
Conversation
ffda563
to
18a2aa5
Compare
@click.option("--no-ray", is_flag=True) | ||
def job(ctx, cluster_name, namespace, no_ray): | ||
""" | ||
List all jobs in a specified RayCluster or in K8S cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not exactly right. in both cases the jobs are being run on K8s clusters. However, they may be run either through the ray or mcad-kubernetes schedulers. In the ray case there will be a "raycluster" that we can reference to get job info. In the mcad-kubernetes case there is only pods that get deployed (as their own short lived "cluster").
So you may want to change this to just "List all jobs submitted".
@click.pass_context | ||
@click.option("--cluster-name", "-c", type=str) | ||
@click.option("--namespace", "-n", type=str) | ||
@click.option("--no-ray", is_flag=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this is --kube-mcad-scheduler-only
@carsonmh Can you rebase this PR? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MichaelClifford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…r view and cancel jobs
New changes are detected. LGTM label has been removed. |
Issue link
closes #277
What changes have been made
Added
list_jobs
functionality incli_utils
get_job
functionality incli_utils
Verification steps
build SDK with
pip install -e .
and run any command withcodeflare
.Checks