View and delete jobs functionality in the CLI #293
Conversation
carsonmh
force-pushed
the
cli-update
branch
2 times, most recently
from
ffda563 to
18a2aa5
Compare
| @click.option("--no-ray", is_flag=True) | ||
| def job(ctx, cluster_name, namespace, no_ray): | ||
| """ | ||
| List all jobs in a specified RayCluster or in K8S cluster |
There was a problem hiding this comment.
This is not exactly right. in both cases the jobs are being run on K8s clusters. However, they may be run either through the ray or mcad-kubernetes schedulers. In the ray case there will be a "raycluster" that we can reference to get job info. In the mcad-kubernetes case there is only pods that get deployed (as their own short lived "cluster").
So you may want to change this to just "List all jobs submitted".
| @click.pass_context | ||
| @click.option("--cluster-name", "-c", type=str) | ||
| @click.option("--namespace", "-n", type=str) | ||
| @click.option("--no-ray", is_flag=True) |
There was a problem hiding this comment.
How about this is --kube-mcad-scheduler-only
|
@carsonmh Can you rebase this PR? |
openshift-merge-robot
added
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MichaelClifford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
…r view and cancel jobs
|
New changes are detected. LGTM label has been removed. |
openshift-merge-robot
removed
the
needs-rebase
Issue link
closes #277
What changes have been made
Added
list_jobsfunctionality incli_utilsget_jobfunctionality incli_utilsVerification steps
build SDK with
pip install -e .and run any command withcodeflare.Checks