Skip to content

remove resource discovery failures #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Conversation

asm582
Copy link
Member

@asm582 asm582 commented Jul 19, 2023

No description provided.

@asm582 asm582 requested review from metalcycling and tardieu July 19, 2023 21:22
@asm582 asm582 changed the base branch from release-v1.29.52 to main July 19, 2023 21:42
@z103cb
Copy link
Contributor

z103cb commented Jul 20, 2023

@asm582 it seems that the changes have been made from a branch that did not have the latest changes to the e2e test. Can you merge main into this PR's branch and re-run the CI ?

@asm582 asm582 changed the base branch from main to release-v1.29.52 July 20, 2023 14:07
@asm582
Copy link
Member Author

asm582 commented Jul 20, 2023

@asm582 it seems that the changes have been made from a branch that did not have the latest changes to the e2e test. Can you merge main into this PR's branch and re-run the CI ?

Thanks, planning to send another PR for main branch

@asm582 asm582 changed the base branch from release-v1.29.52 to release-v1.29.52patch July 20, 2023 15:52
Copy link
Member

@tardieu tardieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asm582 asm582 merged commit 7f72eea into release-v1.29.52patch Jul 21, 2023
asm582 added a commit that referenced this pull request Jul 21, 2023
* remove resource discovery failures

* address review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants