ci: add freebsd target for releases #1660
Conversation
rchincha
requested review from
andaaron and
eusebiu-constantin-petu-dbk
as code owners
|
Related to #1659 |
|
Binary builds going through, checking if container images can be built. |
|
https://github.com/rchincha/zot/actions/runs/5695684455 Container images also being built looks like. However, we need a way to validate them. docker run -it ghcr.io/rchincha/zot-freebsd-amd64:latest |
Codecov Report
@@ Coverage Diff @@
## main #1660 +/- ##
==========================================
- Coverage 91.37% 91.36% -0.01%
==========================================
Files 121 121
Lines 26184 26174 -10
==========================================
- Hits 23925 23915 -10
Misses 1686 1686
Partials 573 573
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Pls. don't merge this yet, would like to get some validation first. |
|
I did look at the container image build yesterday and it should be possible. It would maybe need a freebsd version of ghcr.io/project-zot/golang:1.20 and definitely a freebsd version of gcr.io/distroless/base. Both are probably achievable - I guess project-zot/golang:1.20 is under your control and distroless is on my list (although somewhat low priority at the moment). With those images, the Dockerfile ought to work just fine as long as the resulting image is marked as os=freebsd rather than os=linux. |
|
I looked at ghcr.io/rchincha/zot-freebsd-amd64:latest and it is correctly marked as os=freebsd but looking inside, its using a linux distroless base which will not work |
@dfr do you have a recommendation for a trusted/official minimal freebsd image we can package off of? |
Unfortunately there isn't an official freebsd image yet - I have been advocating for this but it needs to be integrated into the official FreeBSD release engineering workflow which will take some time to get right. In the meantime, I am supplying smallish images which you can use, e.g. quay.io/dougrabson/freebsd-minimal:13.2 or docker.io/dougrabson/freebsd-minimal:13.2. These contain a basic set of core utilities as well as libs so are a bit bigger than distroless-base. I am working on improving the build process for these images so that I can offer something similar to distroless-base but that needs a little more testing before I can push it publically. |
@dfr let's do this in two steps, we will officially release freebsd binaries from our ci pipeline. Once we have an official freebsd minimal image, we can quickly incorporate that into our pipeline. I am going to try your minimal image in my fork though. |
That makes perfect sense - as far as I know, I am the only freebsd user at the moment and I'm comfortable building my own images. I will likely add this to the FreeBSD ports system to make it simple to install for folk who want a bare metal alternative to docker-registry. |
Signed-off-by: Ramkumar Chinchani <[email protected]>
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.