Refactor cluster settings collector #656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor cluster settings collector into new Collector interface. Update tests to use prometheus/testutil to validate the output instead of checking the parsed elasticsearch response. Signed-off-by: Joe Adams <[email protected]>
sysadmind
force-pushed
the
cluster-settings-refactor
branch
from
c2617b9 to
1d4259f
Compare
Signed-off-by: Joe Adams <[email protected]>
jaimeyh
pushed a commit
to sysdiglabs/elasticsearch_exporter
that referenced
this pull request
Jun 14, 2024
* Refactor cluster settings collector Refactor cluster settings collector into new Collector interface. Update tests to use prometheus/testutil to validate the output instead of checking the parsed elasticsearch response. Signed-off-by: Joe Adams <[email protected]> * Fix rebase Signed-off-by: Joe Adams <[email protected]> --------- Signed-off-by: Joe Adams <[email protected]>
jaimeyh
added a commit
to sysdiglabs/elasticsearch_exporter
that referenced
this pull request
Jun 14, 2024
This reverts commit 9bfb1bf.
jaimeyh
added a commit
to sysdiglabs/elasticsearch_exporter
that referenced
this pull request
Jun 14, 2024
This reverts commit 9bfb1bf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor cluster settings collector into new Collector interface. Update tests to use prometheus/testutil to validate the output instead of checking the parsed elasticsearch response.
Signed-off-by: Joe Adams [email protected]