Skip to content

Fixed typos #1363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/content/config/config.md
Original file line number Diff line number Diff line change
Expand Up @@ -122,10 +122,10 @@ This works for all Metrics properties.

<!-- editorconfig-checker-enable -->

(1) Comma sparated list of allowed metric names. Only these metrics will be exposed.<br/>
(2) Comma sparated list of excluded metric names. These metrics will not be exposed.<br/>
(3) Comma sparated list of prefixes. Only metrics starting with these prefixes will be exposed.<br/>
(4) Comma sparated list of prefixes. Metrics starting with these prefixes will not be exposed.<br/>
(1) Comma separated list of allowed metric names. Only these metrics will be exposed.<br/>
(2) Comma separated list of excluded metric names. These metrics will not be exposed.<br/>
(3) Comma separated list of prefixes. Only metrics starting with these prefixes will be exposed.<br/>
(4) Comma separated list of prefixes. Metrics starting with these prefixes will not be exposed.<br/>

## Exporter HTTPServer Properties

Expand Down
8 changes: 4 additions & 4 deletions examples/example-exemplars-tail-sampling/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ There are two ways how to do this:
2. _Tail-based sampling_ is performed by an external infrastructure component like
the [OpenTelemetry collector](https://opentelemetry.io/docs/collector/).

When generating Exemplars, the Prometheus Java client libray must make sure that the Exemplar points
When generating Exemplars, the Prometheus Java client library must make sure that the Exemplar points
to a trace that is
actually sampled. Otherwise, Exemplar's trace ID will not be available in the monitoring backend,
i.e. the Exemplar will
Expand Down Expand Up @@ -95,10 +95,10 @@ The `docker-compose` file will run the example with the following containers:

- `hello-world-app`: Java service described above, with the OpenTelemetry Java instrumentation agent
attached for
distrubted tracing.
distributed tracing.
- `greeting-service`: Java service described above, with the OpenTelemetry Java instrumentation
agent attached for
distrubted tracing.
distributed tracing.
- `collector`: OpenTelemetry collector for receiving the distributed traces, performing _tail
sampling_, and forwarding
them to `tempo`.
Expand All @@ -124,7 +124,7 @@ password _admin_.

## Example Dashboard

The example dashboard shows 50 requests / second for the Java serices:
The example dashboard shows 50 requests / second for the Java services:

![Screenshot showing the request rate on the Java services](https://github.com/prometheus/client_java/assets/330535/9f8dc92e-c9aa-40b6-8fda-a0f7e98560ba) <!-- editorconfig-checker-disable-line -->

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
FROM eclipse-temurin:21-jre

COPY target/example-exporter-opentelemetry.jar ./app.jar
# check that the resource attributs from the agent are used, epsecially the service.instance.id should be the same
# check that the resource attributes from the agent are used, epsecially the service.instance.id should be the same
ADD --chmod=644 https://github.com/open-telemetry/opentelemetry-java-instrumentation/releases/download/v2.8.0/opentelemetry-javaagent.jar /usr/src/app/opentelemetry-javaagent.jar
ENV JAVA_TOOL_OPTIONS=-javaagent:/usr/src/app/opentelemetry-javaagent.jar

Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<automatic.module.name>--module-name-need-to-be-overriden--</automatic.module.name>
<automatic.module.name>--module-name-need-to-be-overridden--</automatic.module.name>
<protobuf-java.version>4.31.0</protobuf-java.version>
<guava.version>33.4.8-jre</guava.version>
<junit-jupiter.version>5.12.2</junit-jupiter.version>
Expand Down