Skip to content

Run update_file_lists.sh #8789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

nipunn1313
Copy link
Contributor

Confirmed it worked via (previously failing)

bazel test //:build_files_updated_unittest

Confirmed it worked via
bazel test //:build_files_updated_unittest
@google-cla google-cla bot added the cla: yes label Jul 3, 2021
@nipunn1313
Copy link
Contributor Author

Please apply labels "Release notes: no" and "cmake" for the relevant area (I think)

Likely something slipped through the cracks allowing the master branch to be red - so it may be wise to follow up on what allowed that through.

@nipunn1313
Copy link
Contributor Author

I'm seeing
image

may want to consider updating the repository settings to allow workflow runs for outside contributors

https://docs.github.com/en/github/administering-a-repository/managing-repository-settings/disabling-or-limiting-github-actions-for-a-repository#configuring-required-approval-for-workflows-from-public-forks

There appears to be settings for "require approval for first time contributors" and a looser setting for "require approval for first time contributors new to github". The latter might avoid this kind of headache for folks like me - so I can proactively make sure tests pass.

@nipunn1313
Copy link
Contributor Author

going to abandon this - feel free to reopen if it seems useful

@nipunn1313 nipunn1313 closed this Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants