Skip to content

Support deserializing binary protobuf encoded message keys #1699

Closed
@jdechicchis

Description

@jdechicchis

First off, Kafka UI is great, thanks for maintaining it!

I noticed this TODO in ProtobufFileRecordSerDe:

//TODO: currently we assume that keys for this serde are always string - need to discuss if it is ok

I think it would be nice to provide the ability to deserialize binary protobuf encoded message keys in addition to message values. To support this, I think a new configuration value such as Map<String, String> protobufMessageNameByTopicForKey could be added (open to suggestions here). In terms of how a message key is deserialized when using ProtobufFileRecordSerDe I feel this precedence order would make sense:

  • If the protobuf message name is found in protobufMessageNameByTopicForKey deserialize the message key using a descriptor.
  • Else, deserialize the message key as a string.

Happy to make a PR for this (I've been playing around with the code and doesn't seem like it would be terribly difficult to add), but wanted to discuss if adding such a configuration makes sense

Metadata

Metadata

Assignees

Labels

scope/backendstatus/acceptedAn issue which has passed triage and has been acceptedtype/enhancementEn enhancement to an already existing feature

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions