Added tests for thread-local caches cleanup. #362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maxim Philippov <[email protected]>
mpwarres
reviewed
Jul 19, 2023
Signed-off-by: Maxim Philippov <[email protected]>
Signed-off-by: Maxim Philippov <[email protected]>
Signed-off-by: Maxim Philippov <[email protected]>
mpwarres
approved these changes
Jul 20, 2023
PiotrSikora
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
I haven't reviewed this, but unblocking it based on @mpwarres's LGTM.
PiotrSikora
changed the title
|
Thanks, and sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for #357. Sorry for not making them in time in original PR 😅