Add polo-smm #2491
Add polo-smm #2491
Conversation
Add the polo spectral model for BIPV facades
There was a problem hiding this comment.
@jesuspolo Thanks for opening your first PR!
I've made some formatting changes, to make sure that the code adheres to the standard flake8 conventions. If you go to the "File changed" tab of this PR, then you can click "Add suggestion to batch" one by one and then commit all of them at once.
Co-authored-by: Adam R. Jensen <[email protected]>
|
@jesuspolo As you can see, the Python Flake8 linter action (shown at the bottom of this PR) failed, due to some formatting not adhering to the Flake8 standard (I guess I didn't manage to spot all of them). If you click the action you can see what still needs to be fixed. Whenever you make changes online and you switch to working on GitHub Desktop, you need to remember to click the "Fetch origin" button to make sure you have the latest changes locally. |
|
Hi Adam, I don't know how to solve the problems, I've seen they are about line too long and spaces, but I don't know how to edit the code and solve (sorry for my few capabilities) |
pvlib/spectrum/mismatch.py
Outdated
| c = { | ||
| 'asi': (0.0056, -0.020, 1.014), | ||
| 'cigs': (-0.0009, -0.0003, 1), | ||
| 'cdte': (0.0021, -0.01, 1.01), | ||
| 'monosi': (0, -0.003, 1.0), | ||
| } | ||
|
|
||
| if module_type is not None: | ||
| if module_type is not None: |
There was a problem hiding this comment.
| if module_type is not None: | |
| if module_type is not None: |
pvlib/spectrum/mismatch.py
Outdated
| [1]. Polo, J., Sanz-saiz, C., Development of spectral mismatch models | ||
| for BIPV applications in building façades Abbreviations : Renew. Energy 245 | ||
| ,122820, 2025.:doi:`10.1016/j.renene.2025.122820` |
There was a problem hiding this comment.
| [1]. Polo, J., Sanz-saiz, C., Development of spectral mismatch models | |
| for BIPV applications in building façades Abbreviations : Renew. Energy 245 | |
| ,122820, 2025.:doi:`10.1016/j.renene.2025.122820` | |
| .. [1] J. Polo and C. Sanz-Saiz, 'Development of spectral mismatch models | |
| for BIPV applications in building façades', Renewable Energy, vol. 245, | |
| p. 122820, Jun. 2025, | |
| :doi:`10.1016/j.renene.2025.122820` |
This is the IEEE citation I get with Zotero.
| albedo=0.2): | ||
| """ | ||
| Estimation of spectral mismatch for BIPV application in vertical facades. | ||
| Parameters |
There was a problem hiding this comment.
| Parameters | |
| Parameters |
I think it won't render well in readthedocs without the margin.
| ---------- | ||
| precipitable_water : numeric | ||
| atmospheric precipitable water. [cm] | ||
|
|
There was a problem hiding this comment.
For consistency.
There was a problem hiding this comment.
Nice PR @jesuspolo !
There are a bunch of tasks to fulfil so this new feature becomes available to users (most of them are in the PR body):
- Reference it in
docs\sphinx\source\reference\effects_on_pv_system_output\spectrum.rst(so it appears in the documentation, once done, we will be able to review the built docs that appear down below) - Add a whatsnew entry in
docs\sphinx\source\whatsnew - Add tests - the better the exhaustive and the most edge-cases they check
| c_albedo = (0.0, 0.0, 1.0) # 0.2 albedo assumed | ||
| albedo = 0.2 |
There was a problem hiding this comment.
I don't know if this is intentional, but this will ignore whatever value the user provides. If it's intentional, the docstring does not reflect that albedo is only used when the type is given, and assumed 0.2 when given the coefficients.
Add test of use of spectral_factor_polo fuction (pull pvlib#2491)
Add the polo spectral model for BIPV facades
[ ] Closes #xxxxdocs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.Adding the spectral model for estimating spectral mismatch for BIPV in facades according to ref: Polo, J., Sanz-saiz, C., 2025. Development of spectral mismatch models for BIPV applications in building façades Abbreviations : Renew. Energy 245, 122820. https://doi.org/10.1016/j.renene.2025.122820