Clean up some warnings in the tests: ivtools/sdm/test__fit_desoto_pvsyst_sandia.py
#2494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linter failure is for a pre-existing style choice, so I will ignore it in this PR. |
cwhanse
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remote-data) and Milestone are assigned to the Pull Request and linked Issue.The tests have been emitting some nuisance numpy warnings for a while: https://github.com/pvlib/pvlib-python/actions/runs/16008866104/job/45161784994#step:9:73
This PR fixes several of them. In the process of doing that, it made sense to refactor some code in
singlediodeto be a little easier to read, and likely marginally faster as well due to avoiding unnecessary repeated array subsetting.I plan to address the remaining warnings in a separate PR.