-
-
Notifications
You must be signed in to change notification settings - Fork 892
Additional scheme endpoints for projects #1295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Zyzyx !
Don't suppose I can trouble you with a test case for this?
It would look very similar to:
jira/tests/resources/test_project.py
Lines 204 to 206 in 064a1cd
def test_project_permissionscheme(self): | |
permissionscheme = self.jira.project_permissionscheme(self.project_b) | |
self.assertEqual(permissionscheme.name, "Default Permission Scheme") |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Bumps [typing-extensions](https://github.com/python/typing) from 3.10.0.2 to 4.1.1. - [Release notes](https://github.com/python/typing/releases) - [Changelog](https://github.com/python/typing/blob/master/typing_extensions/CHANGELOG) - [Commits](python/typing@3.10.0.2...4.1.1) --- updated-dependencies: - dependency-name: typing-extensions dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [coverage](https://github.com/nedbat/coveragepy) from 6.1.2 to 6.3.2. - [Release notes](https://github.com/nedbat/coveragepy/releases) - [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst) - [Commits](nedbat/coveragepy@6.1.2...6.3.2) --- updated-dependencies: - dependency-name: coverage dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [pre-commit.ci] pre-commit autoupdate updates: - [github.com/psf/black: 21.11b1 → 22.1.0](psf/black@21.11b1...22.1.0) - [github.com/pre-commit/pre-commit-hooks: v4.0.1 → v4.1.0](pre-commit/pre-commit-hooks@v4.0.1...v4.1.0) - [github.com/pre-commit/mirrors-mypy.git: v0.910-1 → v0.931](https://github.com/pre-commit/mirrors-mypy.git/compare/v0.910-1...v0.931) - [github.com/asottile/pyupgrade: v2.29.1 → v2.31.0](asottile/pyupgrade@v2.29.1...v2.31.0) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Bumps [pytest-xdist](https://github.com/pytest-dev/pytest-xdist) from 2.4.0 to 2.5.0. - [Release notes](https://github.com/pytest-dev/pytest-xdist/releases) - [Changelog](https://github.com/pytest-dev/pytest-xdist/blob/master/CHANGELOG.rst) - [Commits](pytest-dev/pytest-xdist@v2.4.0...v2.5.0) --- updated-dependencies: - dependency-name: pytest-xdist dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [docutils](http://docutils.sourceforge.net/) from 0.18 to 0.18.1. --- updated-dependencies: - dependency-name: docutils dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [oauthlib](https://github.com/oauthlib/oauthlib) from 3.1.1 to 3.2.0. - [Release notes](https://github.com/oauthlib/oauthlib/releases) - [Changelog](https://github.com/oauthlib/oauthlib/blob/master/CHANGELOG.rst) - [Commits](oauthlib/oauthlib@v3.1.1...v3.2.0) --- updated-dependencies: - dependency-name: oauthlib dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [gssapi](https://github.com/pythongssapi/python-gssapi) from 1.7.2 to 1.7.3. - [Release notes](https://github.com/pythongssapi/python-gssapi/releases) - [Commits](pythongssapi/python-gssapi@v1.7.2...v1.7.3) --- updated-dependencies: - dependency-name: gssapi dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [requests-jwt](https://github.com/tgs/requests-jwt) from 0.5.3 to 0.6.0. - [Release notes](https://github.com/tgs/requests-jwt/releases) - [Commits](tgs/requests-jwt@0.5.3...0.6.0) --- updated-dependencies: - dependency-name: requests-jwt dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [pygments](https://github.com/pygments/pygments) from 2.10.0 to 2.11.2. - [Release notes](https://github.com/pygments/pygments/releases) - [Changelog](https://github.com/pygments/pygments/blob/master/CHANGES) - [Commits](pygments/pygments@2.10.0...2.11.2) --- updated-dependencies: - dependency-name: pygments dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff, a few minor points, but looking good
fix some variable names revert changing some method names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry just being a bit more pedantic here for the public facing functions.
Some other minor superificial changes too
Co-authored-by: Adel Haddad <[email protected]>
for more information, see https://pre-commit.ci
Co-authored-by: Adel Haddad <[email protected]>
for more information, see https://pre-commit.ci
Co-authored-by: Adel Haddad <[email protected]>
Co-authored-by: Adel Haddad <[email protected]>
Co-authored-by: Adel Haddad <[email protected]>
Co-authored-by: Adel Haddad <[email protected]>
See #1294