Skip to content

run pydantic integration tests with lax xfail #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

davidhewitt
Copy link
Contributor

@davidhewitt davidhewitt commented Nov 6, 2023

Change Summary

We seem to be getting in a pattern where we add tests to pydantic which xfail waiting for a release of pydantic-core, this PR makes xpass lax so that these tests don't immediately go red on all pydantic-core PRs until the release.

Possibly one could argue that pydantic-core CI going red due to fixes waiting for release is a desirable thing to add pressure to release, in which case just close this.

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @adriangb

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #1054 (cc41346) into main (3835356) will not change coverage.
Report is 6 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1054   +/-   ##
=======================================
  Coverage   93.36%   93.36%           
=======================================
  Files         106      106           
  Lines       16015    16015           
  Branches       35       35           
=======================================
  Hits        14953    14953           
  Misses       1055     1055           
  Partials        7        7           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3835356...cc41346. Read the comment docs.

Copy link

codspeed-hq bot commented Nov 6, 2023

CodSpeed Performance Report

Merging #1054 will degrade performances by 21.76%

Comparing dh/integration-xfail-lax (cc41346) with main (3835356)

Summary

❌ 1 regressions
✅ 139 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main dh/integration-xfail-lax Change
test_decimal_from_string_core 53.9 µs 68.8 µs -21.76%

@davidhewitt
Copy link
Contributor Author

please review

Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! lgtm 👍

@davidhewitt davidhewitt merged commit d08b4f3 into main Nov 8, 2023
@davidhewitt davidhewitt deleted the dh/integration-xfail-lax branch November 8, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants