-
Notifications
You must be signed in to change notification settings - Fork 290
Add support for Python 3.14 #1714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CodSpeed Performance ReportMerging #1714 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double segmentation fault, ouch.
@@ -71,7 +72,7 @@ linting = [{ include-group = "dev" }, 'griffe', 'pyright', 'ruff', 'mypy'] | |||
wasm = [{ include-group = "dev" }, 'typing_extensions', 'ruff'] | |||
codspeed = [ | |||
# codspeed is only run on CI, with latest version of CPython | |||
'pytest-codspeed; python_version == "3.13" and implementation_name == "cpython"', | |||
'pytest-codspeed; python_version == "3.14" and implementation_name == "cpython"', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'pytest-codspeed; python_version == "3.14" and implementation_name == "cpython"', | |
'pytest-codspeed; python_version == "3.13" and implementation_name == "cpython"', |
(or update the benchmarks job)
We need to wait for uv to ship the beta1, things work with 3.14.0b1 built locally. |
Ah yes, the ABI changed between alpha 6 which this CI ran with and beta 1, so it's no surprise stuff is broken. |
|
It is going to be removed in #1715. |
Different situation for me testing with 3.14b1 free-threaded on Fedora: Test output
|
Change Summary
Related issue number
Checklist
pydantic-core
(except for expected changes)