Refactor sources.py into a subpackage (#546) #548
Conversation
|
@hramezani - My apologies on the large PR - as I mentioned in #546, I couldn't figure out how to make it smaller commits. However, the code was simply a copy and paste from |
Thanks @ezwiefel for this PR. No worries. I am busy these days. I will review it next week |
|
@ezwiefel this PR needs a rebase. but please don't do it now. this is on my list for the next version. So, I will let you know when you need to rebase. I don't want to waste your time to rebase multiple times. my plan is to merge a couple of PRs and then review and merge your PR. Thanks! |
|
@ezwiefel sorry for the delay. You can continue your work now. you can close this PR and open a new one if it is easier. Thanks! |
ezwiefel
force-pushed
the
refactor-sources
branch
from
22afad9 to
a58fe4d
Compare
|
@hramezani - I've rebased the PR and copied any changes that were in |
pydantic_settings/exceptions.py
Outdated
| # Copyright 2025 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. |
There was a problem hiding this comment.
do we need these comments here?
There was a problem hiding this comment.
Sorry - that was auto generated... I'll remove.
|
Thanks @ezwiefel for the update. I only left a small comment. other than that LGTM! |
|
Thanks @ezwiefel |
Refactors
sources.pyinto a submodule namedsources- and then further breaks it down into types, base classes, and providers - with each provider (such asDotEnvSettingsSourceorAzureKeyVaultSettingSource) being put into a seperate module underpydantic_settings.sources.providersResolves #546