Skip to content

Add DGraphFin dynamic graph dataset #5504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 25, 2022
Merged

Conversation

EdisonLeeeee
Copy link
Contributor

@EdisonLeeeee EdisonLeeeee commented Sep 22, 2022

This PR is a re-opened one of #5466. The major difference it that this PR enforces manual download and just provides a process script for the dataset.

Usage

from torch_geometric.datasets import DGraphFin
dataset = DGraphFin("data/DGraphFin")
data = dataset[0]
>>> data
Data(x=[3700550, 17], edge_index=[2, 4300999], edge_attr=[4300999], y=[3700550], edge_time=[4300999], train_mask=[3700550], val_mask=[3700550], test_mask=[3700550])

For now, I used Data instead of TemporalData for storing this dataset.

cc: @Padarn @rusty1s

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Merging #5504 (68ed027) into master (d8d06e1) will decrease coverage by 1.98%.
The diff coverage is n/a.

❗ Current head 68ed027 differs from pull request most recent head 4033475. Consider uploading reports for the commit 4033475 to get more accurate results

@@            Coverage Diff             @@
##           master    #5504      +/-   ##
==========================================
- Coverage   85.76%   83.78%   -1.99%     
==========================================
  Files         346      346              
  Lines       19002    18998       -4     
==========================================
- Hits        16298    15917     -381     
- Misses       2704     3081     +377     
Impacted Files Coverage Δ
torch_geometric/nn/models/dimenet_utils.py 0.00% <0.00%> (-75.52%) ⬇️
torch_geometric/nn/models/dimenet.py 14.51% <0.00%> (-53.00%) ⬇️
torch_geometric/utils/scatter.py 66.66% <0.00%> (-33.34%) ⬇️
torch_geometric/profile/profile.py 37.89% <0.00%> (-26.32%) ⬇️
torch_geometric/nn/conv/utils/typing.py 81.25% <0.00%> (-17.50%) ⬇️
torch_geometric/nn/pool/asap.py 92.10% <0.00%> (-7.90%) ⬇️
torch_geometric/nn/inits.py 67.85% <0.00%> (-7.15%) ⬇️
torch_geometric/transforms/add_self_loops.py 94.44% <0.00%> (-5.56%) ⬇️
torch_geometric/nn/resolver.py 88.88% <0.00%> (-5.56%) ⬇️
torch_geometric/sampler/neighbor_sampler.py 92.90% <0.00%> (-5.17%) ⬇️
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@EdisonLeeeee EdisonLeeeee changed the title Add DGraphFin dynamic graph dataset Add DGraphFin dynamic graph dataset Sep 22, 2022
Copy link
Member

@wsad1 wsad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good. Left some initial comments.

Copy link
Member

@wsad1 wsad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this.

@EdisonLeeeee
Copy link
Contributor Author

EdisonLeeeee commented Sep 24, 2022

Shall I add an example for the use of this dataset?

@EdisonLeeeee
Copy link
Contributor Author

Let's leave the example as the follow-up PR if it is necessary. I think this PR is ready to merge.

Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rusty1s rusty1s enabled auto-merge (squash) September 25, 2022 08:41
@rusty1s rusty1s merged commit 252bc3c into pyg-team:master Sep 25, 2022
@EdisonLeeeee EdisonLeeeee deleted the dgraph branch September 25, 2022 08:48
jjpietrak pushed a commit to jjpietrak/pytorch_geometric that referenced this pull request Nov 25, 2022
* add DGraphFin dynamic graph dataset

* changelog

* overwrite num_classes

* remove __repr__

* typo

* cheatsheet

* update doc-string

* changelog

* Update CHANGELOG.md

* Update torch_geometric/datasets/dgraph.py

* Update torch_geometric/datasets/dgraph.py

Co-authored-by: Matthias Fey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants