-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Add DGraphFin
dynamic graph dataset
#5504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5504 +/- ##
==========================================
- Coverage 85.76% 83.78% -1.99%
==========================================
Files 346 346
Lines 19002 18998 -4
==========================================
- Hits 16298 15917 -381
- Misses 2704 3081 +377
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
DGraphFin
dynamic graph dataset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good. Left some initial comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this.
Shall I add an example for the use of this dataset? |
Let's leave the example as the follow-up PR if it is necessary. I think this PR is ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
* add DGraphFin dynamic graph dataset * changelog * overwrite num_classes * remove __repr__ * typo * cheatsheet * update doc-string * changelog * Update CHANGELOG.md * Update torch_geometric/datasets/dgraph.py * Update torch_geometric/datasets/dgraph.py Co-authored-by: Matthias Fey <[email protected]>
This PR is a re-opened one of #5466. The major difference it that this PR enforces manual download and just provides a process script for the dataset.
Usage
For now, I used
Data
instead ofTemporalData
for storing this dataset.cc: @Padarn @rusty1s