Skip to content

Support np.memmap in NeighborLoader #5696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 14, 2022
Merged

Support np.memmap in NeighborLoader #5696

merged 3 commits into from
Oct 14, 2022

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Oct 14, 2022

No description provided.

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #5696 (00f2b38) into master (52ce0e4) will increase coverage by 0.03%.
The diff coverage is 82.92%.

❗ Current head 00f2b38 differs from pull request most recent head 1f7058c. Consider uploading reports for the commit 1f7058c to get more accurate results

@@            Coverage Diff             @@
##           master    #5696      +/-   ##
==========================================
+ Coverage   83.81%   83.84%   +0.03%     
==========================================
  Files         349      349              
  Lines       19253    19265      +12     
==========================================
+ Hits        16136    16152      +16     
+ Misses       3117     3113       -4     
Impacted Files Coverage Δ
torch_geometric/loader/utils.py 82.80% <68.18%> (+0.37%) ⬆️
torch_geometric/data/storage.py 82.24% <100.00%> (+0.16%) ⬆️
torch_geometric/data/data.py 92.21% <0.00%> (+0.23%) ⬆️
torch_geometric/sampler/utils.py 83.07% <0.00%> (+6.15%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s merged commit 5e75061 into master Oct 14, 2022
@rusty1s rusty1s deleted the numpy_memmap_support branch October 14, 2022 12:34
jjpietrak pushed a commit to jjpietrak/pytorch_geometric that referenced this pull request Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant